Skip to content

Fix out-of-bounds error #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix out-of-bounds error #281

wants to merge 1 commit into from

Conversation

steffann
Copy link

@steffann steffann commented Nov 4, 2018

When checking len(value) >= 2 only value[1] is guaranteed to exist

@steffann
Fix out-of-bounds error
1054a7a 
When checking len(value) >= 2 only value[1] is guaranteed to exist
@jrief
Copy link
Owner

jrief commented Nov 6, 2018

what does the value-tuple actually contain? Wouldn't it be safer to check for if len(value) > 2?

@steffann
Copy link
Author

steffann commented Nov 6, 2018

I don't know what it's supposed to contain. I assumed you would know :) It's not a code path I am actually using. I just noticed the discrepancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steffann @jrief